Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extended dataformat alerts #458

Closed
markoaamunkajo opened this issue Nov 11, 2024 · 8 comments
Closed

Add support for extended dataformat alerts #458

markoaamunkajo opened this issue Nov 11, 2024 · 8 comments
Labels
enhancement New feature or request ready to deploy

Comments

@markoaamunkajo
Copy link
Collaborator

markoaamunkajo commented Nov 11, 2024

Description:

Need to add support for extended data format alerts for following, here are threshold values:

co2: 350 ... 2500
pm, all: 0 ... 250
voc, nox: 0 ... 500
sound: 0 ... 127
luminosity: 0 ... 10000

iOS card: ruuvi/com.ruuvi.station.ios#2184
Android card: ruuvi/com.ruuvi.station#1346

@markoaamunkajo
Copy link
Collaborator Author

@elias it seems that these are not working correctly.

  • Info box is not turned to alert bg colour and no colour in chart. But alert was still triggered.

  • NOx doesn't seem to have setting for alert range.

  • Also there is an alert setting for pm100 which doesn't exist, I think it should be probably pm1.0. or maybe I am confused.

Image
Image
Image
Image
Image
Image
Image

@markoaamunkajo markoaamunkajo added the bug Something isn't working label Nov 21, 2024
@markoaamunkajo
Copy link
Collaborator Author

"PM1.0": 9.0,
"PM2.5": 10.2,
"PM4.0": 10.8,
"PM10.0": 11.2,

These values from gateway history page so I am guessing PM100 is a typo maybe 😄

io53 pushed a commit that referenced this issue Nov 25, 2024
io53 pushed a commit that referenced this issue Nov 25, 2024
@io53 io53 assigned markoaamunkajo and unassigned io53 Nov 25, 2024
@io53
Copy link
Collaborator

io53 commented Nov 25, 2024

"PM1.0": 9.0, "PM2.5": 10.2, "PM4.0": 10.8, "PM10.0": 11.2,

These values from gateway history page so I am guessing PM100 is a typo maybe 😄

The pm10/pm25/pm40/pm100 names comes from alert types https://docs.ruuvi.com/communicate-with-ruuvi-cloud/cloud/user-api#request-body-10
I added them to the localization repo so the should show with clearer title now

@markoaamunkajo
Copy link
Collaborator Author

These are good for me now.

@markoaamunkajo markoaamunkajo added ready to deploy and removed bug Something isn't working labels Nov 26, 2024
@markoaamunkajo
Copy link
Collaborator Author

@io53 for some reason pm1.0 is duplicate and broken in alerts page.

pm1.0.mov

@markoaamunkajo markoaamunkajo added bug Something isn't working and removed ready to deploy labels Dec 2, 2024
io53 pushed a commit that referenced this issue Dec 4, 2024
io53 pushed a commit that referenced this issue Dec 11, 2024
@io53 io53 assigned markoaamunkajo and unassigned io53 Dec 11, 2024
@markoaamunkajo
Copy link
Collaborator Author

@io53
PM 1.0 alert bell didn't get triggered to me when set range to 250-250.
I get email about triggered alert but bell didn't show triggered status next to alert only after a minute or so.

@markoaamunkajo
Copy link
Collaborator Author

@io53 the bell triggering logic is not the same with pm 1.0 as it is for example for temperature. If measured value is already in alert triggering threshold when alert is activated the bell should start blinking right away.

@markoaamunkajo
Copy link
Collaborator Author

QA passed

@markoaamunkajo markoaamunkajo assigned io53 and unassigned markoaamunkajo Jan 9, 2025
@markoaamunkajo markoaamunkajo added ready to deploy and removed bug Something isn't working labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to deploy
Projects
None yet
Development

No branches or pull requests

2 participants