Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumpy menu in sensor settings page #2121

Open
markoaamunkajo opened this issue Aug 19, 2024 · 5 comments
Open

Fix jumpy menu in sensor settings page #2121

markoaamunkajo opened this issue Aug 19, 2024 · 5 comments
Assignees
Labels
bug Something isn't working investigation
Milestone

Comments

@markoaamunkajo
Copy link
Collaborator

Description:

The collapsible menu in sensor settings page has still some issues.
I tested this in landscape mode where it's quite visible.

collapsible_iphone14pro.mov
@markoaamunkajo markoaamunkajo added the bug Something isn't working label Aug 19, 2024
@markoaamunkajo
Copy link
Collaborator Author

This is not high priority but a good fix to make

@priyonto priyonto added this to the 2.11 milestone Aug 19, 2024
@markoaamunkajo markoaamunkajo modified the milestones: 2.11, 2.12, 2.13 Sep 5, 2024
priyonto added a commit that referenced this issue Dec 1, 2024
Hide alerts when sensor is not present #2196
Fix jumpy menu on alerts #2121
priyonto added a commit that referenced this issue Dec 1, 2024
Hide alerts when sensor is not present #2196
Fix jumpy menu on alerts #2121
@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Dec 1, 2024
@priyonto
Copy link
Collaborator

priyonto commented Dec 1, 2024

Hopefully fixed or at least made it better as part of #2184. If this doesn't fix it we have to do significant changes on the layout setup code.

@markoaamunkajo
Copy link
Collaborator Author

Mostly fixed, only bigger noticeable glitch happened when closing section at bottom of screen.

bottom-of-screen.mov

@priyonto
Copy link
Collaborator

priyonto commented Dec 2, 2024

@markoaamunkajo How critical is this to get it properly fixed? This will require I think some good refactoring of layout setup code.

@markoaamunkajo
Copy link
Collaborator Author

Closing as will be revisited as part of sensor settings V2 card

@priyonto priyonto self-assigned this Jan 3, 2025
@priyonto priyonto reopened this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigation
Projects
None yet
Development

No branches or pull requests

2 participants