Add and fix JSON stack overflow tests #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON test suite (https://github.com/nst/JSONTestSuite/) contains a list of JSON test files, two of which which triggered crashes. n_structure_100000_opening_arrays.json n_structure_open_array_object.json These crashes were both caused by excessive recursion as they created massively deep arrays and objects. These test examples have been added to test-strings. Modifications were alse made to the test runners to support them. An arbitrary depth cap has been added to the parser prevent the overflow problem.
Repeated calls to parse_value() where parse_object() or parse_array() failed would lead to an accumulation of the depth value. The other way of fixing this would be to reset depth in json_decode()
|
Clang tests failing, looks like this error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
The JSON test suite (https://github.com/nst/JSONTestSuite/) contains
a list of JSON test files, two of which which triggered crashes.
n_structure_100000_opening_arrays.json
n_structure_open_array_object.json
These crashes were both caused by excessive recursion as they created
massively deep arrays and objects.
These test examples have been added to test-strings.
Modifications were alse made to the test runners to support them.
An arbitrary depth cap has been added to the parser prevent the
overflow problem.