Tok itr #12
Open
Tok itr #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterates over tokens in a string which are separated by a delimiter without modifying the string.
the first draft of this module made it impossible for a user of the module to prevent truncation of tokens in the case where a token exceeded the length of the buffer passed to tok_itr_val. these changes rearrange the code so that the length of the token is known before a call to tok_itr_val. since the length of the token is known before hand, an appropriately sized buffer can be allocated for each token before making a call to tok_itr_val.
also removed some trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Rusty,
Here is another pull request with changes based on your suggestions. Ive sent an email to the list with an explanation.