Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add libccan.a target #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SimonVrouwe
Copy link

@SimonVrouwe SimonVrouwe commented Jan 13, 2023

The example Makefile-ccan is broken.

Not sure if this is unusual to add this target, but I find this convenient to play around:

cd ccan
make libccan.a
cd ..
gcc -g play.c -I./ccan -L./ccan -lccan
./a.out

rustyrussell and others added 2 commits January 9, 2023 12:36
Seems to be happening with gcc 12.2.0-3ubuntu1:

```
lightningd/jsonrpc.c: In function ‘destroy_json_command’:
lightningd/jsonrpc.c:1180:63: error: the comparison will always evaluate as ‘false’ for the address of ‘canary’ will never be NULL [-Werror=address]
lightningd/jsonrpc.c:108:53: note: ‘canary’ declared here
```

Signed-off-by: Rusty Russell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants