Skip to content

Commit

Permalink
twinkle: Move nuisance error to console (wikimedia-gadgets#1998) (wik…
Browse files Browse the repository at this point in the history
…imedia-gadgets#2002)

The error message for a failed network request to get preferences is now
logged to console instead of being shown as a popup. The error fires
if the user navigates away from the page before the request completes,
leading to unwanted popups.
  • Loading branch information
TollensWP authored and rustykitty committed Dec 1, 2024
1 parent f6564c9 commit c5011c7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion twinkle.js
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ $.ajax({
dataType: 'text'
})
.fail(function () {
mw.notify('Could not load your Twinkle preferences, resorting to default preferences');
console.log('Could not load your Twinkle preferences, resorting to default preferences'); // eslint-disable-line no-console
})
.done(function (optionsText) {

Expand Down

0 comments on commit c5011c7

Please sign in to comment.