Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FIREURLD_BROWSER environment variable for daemon #10

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

a-ilin
Copy link
Contributor

@a-ilin a-ilin commented Jun 27, 2024

This PR introduces a different environment variable to be used by fireurld daemon: FIREURLD_BROWSER.

Separate environment variables for client and daemon allow chaining execution from daemon to client using xdg-open.

Example scheme where FIREURLD_BROWSER differs from FIREURL_BROWSER. Assuming a user clicks a link within a containerized application (not browser). By default an application calls xdg-open, which handles the request:

xdg-open (container)
v
fireurl (container)
v
fireurld (host)
v
xdg-open (host)
v
fireurl (host)
v
firefox

In the scheme above:

  • FIREURL_BROWSER: default (firefox)
  • FIREURLD_BROWSER: xdg-open

Chaining from one container into another, as well, as from host to a container is also possible. The dispatch is based on the MimeType property of XDG desktop files.

Containerized applications accepting external requests may specify Exec property as a script starting the new application instance via firejail or using existing instance via nsenter commands.

Copy link
Owner

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusty-snake rusty-snake merged commit 557216d into rusty-snake:main Jun 27, 2024
@rusty-snake
Copy link
Owner

Thanks for this contribution!

@a-ilin a-ilin deleted the daemon_env_var branch June 27, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants