Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing on nightly #13

Open
Hywan opened this issue Aug 14, 2018 · 2 comments
Open

Tests are failing on nightly #13

Hywan opened this issue Aug 14, 2018 · 2 comments

Comments

@Hywan
Copy link
Contributor

Hywan commented Aug 14, 2018

$ rustup update nightly
… latest update on 2018-08-14, rust version 1.30.0-nightly (d5a448b3f 2018-08-13) …

$ cargo test
fail because the “name” section is not in the WASM binary

This can be viewed with:

$ cd tests
$ rustc +nightly --target wasm32-unknown-unknown -O -g ./hello.rs
$ twiggy top hello.wasm | head -n 15
 Shallow Bytes │ Shallow % │ Item
───────────────┼───────────┼──────────────────────
          3460 ┊     6.68% ┊ code[119]
          3169 ┊     6.12% ┊ data[0]
          1581 ┊     3.05% ┊ code[170]
          1304 ┊     2.52% ┊ code[177]
          1210 ┊     2.34% ┊ code[154]
          1113 ┊     2.15% ┊ code[165]
           942 ┊     1.82% ┊ code[168]
           926 ┊     1.79% ┊ code[124]
           747 ┊     1.44% ┊ code[122]
           710 ┊     1.37% ┊ code[148]
           696 ┊     1.34% ┊ code[184]
           695 ┊     1.34% ┊ code[19]
           694 ┊     1.34% ┊ code[149]

The debug symbols are missing.

If we remove the -O option, it's working. I suspect this is a regression in rustc.

@Hywan
Copy link
Contributor Author

Hywan commented Aug 14, 2018

I suspect it can be related to rust-lang/rust#52887.

Hywan added a commit to Hywan/gutenberg-parser-rs that referenced this issue Aug 14, 2018
The WASM binary is heavier but it compiles. See rustwasm/wasm-snip#13.
@Hywan
Copy link
Contributor Author

Hywan commented Aug 29, 2018

Follow up rust-lang/rust#53434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant