Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows path output is unneccesarily escaped #390

Closed
steveklabnik opened this issue Oct 4, 2018 · 0 comments · Fixed by #396
Closed

Windows path output is unneccesarily escaped #390

steveklabnik opened this issue Oct 4, 2018 · 0 comments · Fixed by #396
Labels
changelog - fix
Milestone
0.6.0

Comments

@steveklabnik
Copy link
Contributor

🐛 Bug description

When I run wasm-pack, I get a final output that looks like this

| :-) Your wasm pkg is ready to publish at "\\\\?\\C:\\Users\\Steve Klabnik\\tmp\\wasm-bug\\pkg".

🤔 Expected Behavior

It should look like this:

| :-) Your wasm pkg is ready to publish at "\\?\C:\Users\Steve Klabnik\tmp\wasm-bug\pkg".

👟 Steps to reproduce

Build the hello world template on Windows.

🌍 Your environment

wasm-pack version: wasm-pack 0.5.0
rustc version: rustc 1.31.0-nightly (5597ee8a6 2018-10-03)
@ashleygwilliams ashleygwilliams added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers to-do stuff that needs to happen, so plz do it k thx labels Oct 4, 2018
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Oct 4, 2018
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Oct 5, 2018
@huangjj27
bugfix(command/build.rs): Cancel Escape
be0bc12 
fix rustwasm#390
@huangjj27 huangjj27 mentioned this issue Oct 5, 2018
Merged
3 tasks
@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 5, 2018
@xmclark xmclark mentioned this issue Oct 6, 2018
Merged
This was referenced Oct 13, 2018
Closed
Closed
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Oct 16, 2018
@huangjj27
bugfix(command/build): passing test case
945cb76 
this commit fixes rustwasm#390, rustwasm#414, and closes rustwasm#408 for the test case
have to pass after a successful build.
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Oct 20, 2018
@huangjj27
bugfix(command/build.rs): Cancel Escape
8bfcf17 
fix rustwasm#390
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Oct 20, 2018
@huangjj27
bugfix(command/build): passing test case
f7ce0b6 
this commit fixes rustwasm#390, rustwasm#414, and closes rustwasm#408 for the test case
have to pass after a successful build.
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Oct 30, 2018
@huangjj27
bugfix(command/build.rs): Cancel Escape
a55c11d 
fix rustwasm#390
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Oct 30, 2018
@huangjj27
bugfix(command/build): passing test case
9fa7311 
this commit fixes rustwasm#390, rustwasm#414, and closes rustwasm#408 for the test case
have to pass after a successful build.
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Nov 8, 2018
@huangjj27
bugfix(command/build.rs): Cancel Escape
27aa829 
fix rustwasm#390
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Nov 8, 2018
@huangjj27
bugfix(command/build): passing test case
08cfdff 
this commit fixes rustwasm#390, rustwasm#414, and closes rustwasm#408 for the test case
have to pass after a successful build.
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Nov 17, 2018
@huangjj27
bugfix(command/build.rs): Cancel Escape
c98287f 
fix rustwasm#390
huangjj27 added a commit to huangjj27/wasm-pack that referenced this issue Nov 17, 2018
@huangjj27
bugfix(command/build): passing test case
cf56fa1 
this commit fixes rustwasm#390, rustwasm#414, and closes rustwasm#408 for the test case
have to pass after a successful build.
@ashleygwilliams ashleygwilliams added changelog - fix and removed PR attached there's a PR open for this issue bug Something isn't working hacktoberfest to-do stuff that needs to happen, so plz do it k thx labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog - fix
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

bugfix(command/build.rs): Cancel Escape huangjj27/wasm-pack
2 participants
@steveklabnik @ashleygwilliams