Remove experimental interface types support #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Mar 27, 2023
Namely `Generated` being an enum and the `trap` fields of `Instruction::IntToWasm` and `Instruction::WasmToInt`.
For some reason wasm-bindgen would only allow enabling multi-value if interface types were enabled, throwing an error otherwise. I couldn't see any reason why, so I changed that. Since that also meant that multi-value + JS bindings wasn't being tested, allowing it exposed some bugs that I fixed.
|
While working on this I noticed that wasm-bindgen throws an error if you try to use the multi-value transform without interface types enabled. I couldn't see any reason for that, so I've gotten rid of that check. |
Liamolucko
changed the title
|
Now that this is merged, I assume the next release will be semver breaking (0.3.0)? We should create a tracking issue/check list for that |
|
I don't think this is a breaking change, so this should be good to keep up with the 0.2 track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work-in-progress, I'm just opening this as a draft to make sure CI is passing.
This PR removes
wasm-bindgen's experimental support for interface types. This is because it relies heavily on the archivedwit-*family of crates, which are now triggering future incompatibility warnings, as reported in #3356.The support is far out of date with the upstream component model, so it wouldn't have been particularly useful in its current state anyway.