Implement FromStr for JsString #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jules-Bertholet
force-pushed
the
implement-traits
branch
2 times, most recently
from
18f2281
to
5e5dbd9
Compare
src/lib.rs
Outdated
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| Ok(Self::from_str(s)) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm a bit hesitatnt to have this impl since JsValue is so generic. Often FromStr is used in parsing contexts so one might expect this to parse a float, for example, rather than producing a string value.
Is this required by a use case of yours or would it be ok to leave it out for now?
There was a problem hiding this comment.
No, I don't need this for anything, I just noticed while adding other impls that this one would be easy to add in as well. I'll remove it
Jules-Bertholet
force-pushed
the
implement-traits
branch
from
5e5dbd9
to
94e19a8
Compare
Jules-Bertholet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.