Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated comment about path dependency. #2129

Conversation

mstange
Copy link
Contributor

@mstange mstange commented May 11, 2020

The "Hello, World!" chapter of the wasm-bindgen Guide contains an sentence about a path dependency in the Cargo.toml section: https://rustwasm.github.io/docs/wasm-bindgen/examples/hello-world.html

The Cargo.toml enables depends on the wasm-bindgen crate. Here we're using a path dependency because this example lives in the wasm-bindgen repository itself, but you'd use the commented out version beneath it instead.

But then the quoted code section shows a regular version dependency:

[dependencies]
wasm-bindgen = "0.2.62"

The path dependency was turned into a regular version dependency in PR #1015.

This PR also changes the phrasing in the preceding sentence, to eliminate the odd "enables depends" fragment.

The path dependency was turned into a regular version dependency in PR rustwasm#1015, so it doesn't need to be
called out as special anymore.
This commit also changes the phrasing in the preceding sentence.
@alexcrichton alexcrichton merged commit 6b5f734 into rustwasm:master May 11, 2020
@alexcrichton
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants