Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been quite a few issues (1, 2, 3) about TypedArrays and Rust slices.
Right now the only way to convert a Rust slice into a TypedArray is to use the unsafe
view
function. But it's common for people to make mistakes when using it, and those mistakes are quite bad (since it'sunsafe
).So this PR adds in safe
From
impls for all of the TypedArrays, allowing for easy, safe, and fast conversion from Rust slices.