Fix conditional #[wasm_bindgen] in impls #1208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #1191 the fix requires us to get a bit creative I think. The
general gist is that a block like this:
was previously expanded all in one go. Now, however, it's expanded into:
This method of expansion takes advantage of rustc's recursive expansion
feature. It also allows us to expand
impl
blocks and allow inner itemsto not be fully expanded yet, such as still having
#[cfg]
attributes(like in the original bug report).
We use theinternal
__wasm_bindgen_class_marker
to indicate that we'reparsing an
ImplItemMethod
unconditionally, and then generationproceeds as usual. The only final catch is that when we're expanding in
an
impl
block we have to generate tokens for theProgram
(wasm-bindgen injected goop like the custom section) inside the body
of the function itself instead of next to it. Otherwise we'd get syntax
errors inside of impl blocks!
Closes #1191