Rename iterator types and add some docs #1077
Conversation
|
I've thrown away my alternative implementation, and added some new names/docs to help anyone else like me to understand the design decisions that have been made. |
There was a problem hiding this comment.
Sorry for the delay responding to this! Was at the mozilla all hands last week doing lots of mozilla planning stuff and meetings and all that.
The documentation looks amazing! Thanks so much for that.
However, the renaming is a breaking change, and I don't think this rename is quite worth subjecting the community to a breaking change for.
Is the idea to create space for the typed iterators we were talking about in the other issue? If so, I think we can use TypedIterator<T> or something like that and avoid the breaking change.
Am I missing something about the rename here? Assuming not, then I'm happy to merge the docs in this PR without the rename!
|
I think this has gone somewhat stale over time, so I'm gonna go ahead and close this. It can of course be resubmitted with feedback addressed though! |
Continued from #1043.