Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create advisory for unmainted in serde_yaml #2023

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BobG1983
Copy link

Can't raise an issue on serde_yaml as the repo is archived.

@deg4uss3r
Copy link

Is it possible to get this one merged in?

@sanpii
Copy link
Contributor

sanpii commented Oct 19, 2024

Available alternatives:

@decathorpe
Copy link
Contributor

FWIW I've had personal email correspondence with dtolnay when the project was initially marked as "deprecated" and archived on GitHub, and he confirmed that he will do no further work on serde_yaml and unsafe-libyaml.

Comment on lines +3 to +30
# Identifier for the advisory (mandatory). Will be assigned a "RUSTSEC-YYYY-NNNN"
# identifier e.g. RUSTSEC-2018-0001. Please use "RUSTSEC-0000-0000" in PRs.
id = "RUSTSEC-0000-0000"

# Name of the affected crate (mandatory)
package = "serde_yaml"

# Disclosure date of the advisory as an RFC 3339 date (mandatory)
date = "2024-07-21"

# URL to a long-form description of this issue, e.g. a GitHub issue/PR,
# a change log entry, or a blogpost announcing the release (optional, except
# for advisories using a license that requires attribution).
url = "https://github.com/dtolnay/serde-yaml/blob/master/README.md"

# Optional: Indicates the type of informational security advisory
# - "unsound" for soundness issues
# - "unmaintained" for crates that are no longer maintained
# - "notice" for other informational notices
informational = "unmaintained"

# Freeform keywords which describe this vulnerability, similar to Cargo (optional)
keywords = ["yaml", "serde", "serialization"]

# Versions which include fixes for this vulnerability (mandatory)
# All selectors supported by Cargo are supported here:
# https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html
# use patched = [] e.g. in case of unmaintained where there is no fix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comments

@kornelski
Copy link
Contributor

dtolnay reports that serde_yml has soundness issues and AI-hallucinated slop:

https://old.reddit.com/r/rust/comments/1ibdxf9/beware_of_this_guy_making_slop_crates_with_ai/

@tarcieri
Copy link
Member

It would also be good to add alternatives. There's a list in #2132, though as noted earlier we probably shouldn't add serde_yml (#2212)

@tarcieri
Copy link
Member

Also since this PR seems to be stalled, perhaps someone else could open another?

@Sytten
Copy link

Sytten commented Jan 29, 2025

I am personally opposed to this kind of advisory, all that it will do is push people toward crates that are shady like serde_yml to make github advisory happy. This doesnt improve security in any meaningful way if anything it is the inverse. If there was a clear and good replacement it would be another story but as things currently stand this would be a net negative IMO.

@tarcieri
Copy link
Member

tarcieri commented Jan 29, 2025

@Sytten as stated earlier, this advisory explicitly shouldn't list serde_yml as a suggested replacement, and instead the advisory can explicitly advise NOT to use serde_yml

@BlackHoleFox
Copy link
Contributor

On Sytten's point, I think the value add of unmaintained advisories is worth discussion especially as they seem to surface by default these days or so because everyone tends to deny audit warnings and that enables unmaintained informational ones too. @tarcieri do you want a separate issue for that discussion or are you ok with me (and maybe others) writing thoughts here?

@tarcieri
Copy link
Member

This is definitely not the place to debate the value of unmaintained advisories.

I am personally exhausted and very burned out from past debates on this topic, which have included things like Reddit brigading. Rekindling ad hoc debates about the value of unmaintained advisories yet again risks me burning out on the project.

It would be much more helpful to make constructive suggestions about how they can be improved, or if you feel the rationale for their existence is not properly described, helpfully describe what you would like to see.


# serde_yaml - no longer maintained

The creator of serde_yaml has stated in the readme of their repo that the lib is no longer maintained, and also marked versoin 0.9.34 as deprecated.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The creator of serde_yaml has stated in the readme of their repo that the lib is no longer maintained, and also marked versoin 0.9.34 as deprecated.
The creator of serde_yaml has stated in the readme of their repo that the lib is no longer maintained, and also marked version 0.9.34 as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants