Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure examples use re-exported rustls types outside of the tokio-rustls context #56

Merged

Conversation

mdodkins
Copy link
Contributor

Addresses an issue I encountered trying to use the client and server examples in standalone projects:

the trait From<Arc<rustls::ServerConfig>> is not implemented for TlsAcceptor
the trait From<Arc<rustls::ClientConfig>> is not implemented for TlsConnector

These modifications ensure that the code uses rustls types re-exported by tokio-rustls when compiled in a context outside of the library.

examples/client.rs Outdated Show resolved Hide resolved
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@djc djc merged commit 925a87f into rustls:main Mar 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants