Remove dependency on rustls #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
no-rustls
branch
3 times, most recently
from
4651698 to
6116ef5
Compare
|
This now includes the commits from #27 to make sure these changes work. |
|
Updated this to depend on rustls 0.20 for the tests. Would be nice to get this merged and published to unblock downstream users (as always, I'm happy to work on that myself -- would follow a similar release process as outlined in the rustls release process -- would it be helpful to copy that in this repository?). |
ctz
approved these changes
Oct 9, 2021
|
Any chance to get a new release with this soon-ish, or are you waiting for some other things first? |
|
We definitely plan to publish a new release soon. |
This was referenced Oct 11, 2021
Closed
g2p
added a commit
to g2p/hyper-rustls
that referenced
this pull request
Oct 18, 2021
rustls-native-certs used to filter out invalid certs on Unix, where certs are parsed from PEM files. rustls/rustls-native-certs#26 changed it to passing them unparsed. Now that hyper-rustls does the parsing, keep being robust to invalid certs. Implementation modified from rustls::RootCertStore::add_parsable_certificates, which cannot be used directly due to a newtype in rustls-native-certs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a simpler API that just returns a
Vec<Certificate>, whereCertificateis a newtype wrapper overVec<u8>(as is done in rustls itself), relying on rustls-pemfile for PEM parsing.