Allow building without the pem crate feature
#204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind adding a CI job that tests for this, to help us avoid regressing this again? |
daxpedda
commented
Dec 19, 2023
daxpedda
force-pushed
the
build-without-pem
branch
from
1e7fb6e to
00765e0
Compare
This is from the branch protection rules falling out of sync with the updated matrix-based task name. I think we should merge without waiting for requirements to be met and then fix those rules. |
|
I think this warrants a 0.12.1 bugfix release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trying to build like this:
will fail because it can't find
pem::PemErrororError::PemError.Simply adding a
cfgguard on this implementation fixes the issue.