Create some traits for swapping/flushing screen buffers #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ian Chamberlain <[email protected]>
Oops! The argument to `gfxScreenSwapBuffers` is gfxScreen_t, not gfx3dSide_t ! Unfortunately they are both alias to libc::c_uint so we didn't get any help from the Rust compiler when passing the screen side into this function.
Rename to flush_buffers, and just have TopScreen3D's impl do both. This still allows individual flushing of left and right if needed but most people would probably just use `TopScreen3D::flush_buffers`.
AzureMarker
approved these changes
Apr 14, 2023
1 task
Clarify the behavior of `swap_buffers` for single buffering mode and update bitmap example to prove that this is actually how it works.
ian-h-chamberlain
force-pushed
the
feat/flush-swap-screen-traits
branch
from
353992a to
b239fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #116 (comment)
I tried to implement this, it seems to work mostly for compile time checks at least, but I haven't tested that it actually works as expected when running. Let me know what you think, maybe this is a slightly better API to make it clearer that both left + right top screen buffers have to be swapped at once?