[Rebased] [x11-backend] Retrieve DPI from Xft.dpi XResource #824
Conversation
|
Just FYI - I've talked with @francesca64 and it seems she no longer has the time to maintain the X11 backend, so I wouldn't expect to see a review from her. I'm intending to open an issue for broader discussion on maintainership for her current backends once I have a clearer picture of what her availability for work on the android/macos is, but in the meanwhile I'd be willing to merge this once someone else tests it. |
There was a problem hiding this comment.
It took me a while to realize that I need to call xrdb ~/.Xresources to reload my .Xresources, but after doing that I discovered that this works as intended.
I was concerned that we might have to release the memory returned by XResourceManagerString, but I found this nugget in the xlib docs (https://tronche.com/gui/x/xlib/resource-manager/XResourceManagerString.html):
The returned string is owned by Xlib and should not be freed by the client.
lgtm
* [x11-backend] Retrieve DPI from Xft.dpi XResource * Update CHANGELOG.md * Update window.rs * Update CHANGELOG.md
…dowing#824) * [x11-backend] Retrieve DPI from Xft.dpi XResource * Update CHANGELOG.md * Update window.rs * Update CHANGELOG.md
…dowing#824) * [x11-backend] Retrieve DPI from Xft.dpi XResource * Update CHANGELOG.md * Update window.rs * Update CHANGELOG.md
This is @semtexzv's fix for DPI behaviour on x11 at #606 rebased onto master. I just tested both master and this rebased branch locally and this branch still fixes my DPI problem on x11.
CHANGELOG.mdif knowledge of this change could be valuable to usersCreated an example program if it would help users understand this functionalityedit: cc @francesca64 I just noticed you were ready to merge this a while back, just thought I'd ping you!