unix::WindowExt no longer returns pointers for things that aren't actually pointers #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, the PR looks good. |
…ually pointers Fixes rust-windowing#256 `get_xlib_window` and `get_xlib_screen_id` previously returned `Option<*mut c_void>` by casting integer IDs into pointers, which while producing no functionality issues, is semantically incorrect and rather surprising. Worse still, the docs for `get_xlib_window` stated that it was in fact a valid pointer. Additionally, now all `unix::WindowExt` methods return `std::os::raw` types rather than `libc` types; note that the two versions of `c_void` are not interchangeable in the eyes of the compiler, so those wanting the `libc` type will need to explicitly cast. This is a breaking change, and will require some trivial changes to glutin.
francesca64
force-pushed
the
unix-windowext-pointers
branch
from
9e8af57 to
32d76ef
Compare
|
I've changed the other methods of |
francesca64
added a commit
to francesca64/winit
that referenced
this pull request
Dec 24, 2017
…en't actually pointers (rust-windowing#364)" This reverts commit 23e4293.
tmfink
pushed a commit
to tmfink/winit
that referenced
this pull request
Jan 5, 2022
Expose OpenGL 4.x in the C bindings Closes rust-windowing#352.
madsmtm
pushed a commit
to madsmtm/winit
that referenced
this pull request
Jun 11, 2022
Co-authored-by: wusyong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
get_xlib_windowandget_xlib_screen_idpreviously returnedOption<*mut c_void>by casting integer IDs into pointers, which while producing no functionality issues, is semantically incorrect and rather surprising. Worse still, the docs forget_xlib_windowstated that it was in fact a valid pointer.This is a breaking change, and will require some trivial changes to glutin.
I chose to have
get_xlib_windowreturnOption<libc::c_ulong>rather thanOption<ffi::Window>, since I assumeffi::Windowisn't supposed to be exposed.