Add typos - Source code spell checker #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the current implementation takes around 8 seconds. So it's faster and it seems more thorough as well. So I'm ready to switch to this instead of @rust-windowing/winit Thoughts? |
daxpedda
requested changes
Mar 5, 2024
kchibisov
approved these changes
Mar 5, 2024
|
This fixes the same typos as #3556. Do I removed them from here and wait for the other pr to be merged, or I keep them? |
No, will merge your patch instead fixing them. |
kchibisov
approved these changes
Mar 5, 2024
|
squashed |
ameknite
force-pushed
the
add-typos
branch
2 times, most recently
from
0a9e598 to
6b4c99e
Compare
daxpedda
approved these changes
Mar 6, 2024
notgull
approved these changes
Mar 7, 2024
Given that typos are frequent and may appear in the public API spell check code on CI.
|
@ameknite I've rebased things myself. |
This was referenced Mar 12, 2024
notgull
added a commit
to forkgull/glutin
that referenced
this pull request
Mar 12, 2024
As per the precedent set in winit, adds a spellchecker using the typos crate to CI. cc rust-windowing/winit#3565 Signed-off-by: John Nunley <[email protected]>
4 tasks
kchibisov
pushed a commit
to rust-windowing/glutin
that referenced
this pull request
Mar 13, 2024
As per the precedent set in winit, adds a spellchecker using the typos crate to CI. Links: rust-windowing/winit#3565 Signed-off-by: John Nunley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3557 but with typos
Advantages:
For reference typos is used in:
Bevy - bevyengine/bevy#12036
Wgpu - gfx-rs/wgpu#5191