Fix nightly CI #3526
Merged
Fix nightly CI #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
nightly-ci-2
branch
from
b462573
to
8dadd2f
Compare
kchibisov
approved these changes
Feb 26, 2024
|
Doign some research on rust-lang/rust#121621 right now, apparently the conclusion might be that this is not an FP. |
|
After some more testing and reading I'm not exactly confident if this is an FP or not, but I will keep an eye on it and eventually update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3525.
Currently nightly fails because of FPs introduced by the new
non_local_definitionslint.FPs are tracked in rust-lang/rust#121621.