On X11, cleanup event processor implementation #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
force-pushed
the
kchibisov/x11-event-processor
branch
2 times, most recently
from
8a8f95b to
464db0f
Compare
5 tasks
Remove the redundant `Rc` to access the window target.
Make code more clear wrt explicit returns during event handling, which may lead to skipped IME event handling.
kchibisov
force-pushed
the
kchibisov/x11-event-processor
branch
from
464db0f to
d643b1a
Compare
notgull
approved these changes
Feb 10, 2024
| return; | ||
| } | ||
|
|
||
| if xev.data.get_long(0) as xproto::Atom == wt.net_wm_ping { |
There was a problem hiding this comment.
Nit: We should use else if instead of if.
There was a problem hiding this comment.
it just was insanely long else if. in general i'd probably rewrite this to something else, but not right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--
I basically moved the code around, both commits should build and show what I've tried to achieve.