Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On macOS, report correct logical key when Ctrl or Cmd is pressed #3361

Merged
merged 6 commits into from
Jan 5, 2024
Merged

On macOS, report correct logical key when Ctrl or Cmd is pressed #3361

merged 6 commits into from
Jan 5, 2024

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Jan 5, 2024

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@emilk emilk requested a review from madsmtm as a code owner January 5, 2024 08:32
This was referenced Jan 5, 2024
Closed
Open
Open
Merged
kchibisov
kchibisov requested changes Jan 5, 2024
View reviewed changes
src/platform_impl/macos/event.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/event.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/event.rs Outdated Show resolved Hide resolved
@kchibisov
Copy link
Member

You'll also need a changelog entry for this.

@emilk
Copy link
Contributor Author

emilk commented Jan 5, 2024

Comments addressed, and there is a changelog entry

@emilk
Copy link
Contributor Author

emilk commented Jan 5, 2024

Thanks for the review!

@kchibisov kchibisov merged commit b1209bc into rust-windowing:master Jan 5, 2024
51 checks passed
@emilk
Copy link
Contributor Author

emilk commented Jan 5, 2024 •
edited
Loading

I think this would be a good candidate to include in the next patch release

Wow, it has already been releases 🤯 Thanks ❤️

@kchibisov
Copy link
Member

I already released it in 0.29.9

This was referenced Jan 26, 2024
Open
Closed
@kchibisov
Copy link
Member

It seems like it regressed this alacritty/alacritty#7742

where command is mandatory to produce the correct binding.

@madsmtm madsmtm mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov approved these changes

@madsmtm madsmtm Awaiting requested review from madsmtm

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMD+Shift is not reported correctly on macOS
2 participants
@emilk @kchibisov