Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass force on touch events on android #3020

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

lucasmerlin
Copy link
Contributor

@lucasmerlin lucasmerlin commented Aug 11, 2023

Adds pressure data to touch events on android

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Comment on lines 478 to 480
force: Some(crate::event::Force::Normalized(
pointer.pressure() as f64
)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you import it at the top properly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@kchibisov
Copy link
Member

@lucasmerlin could you rebase, seems like CI is stuck...

@lucasmerlin lucasmerlin force-pushed the fix_android_touch_force branch from cee479b to e55246a Compare September 8, 2023 10:03
@lucasmerlin
Copy link
Contributor Author

@lucasmerlin could you rebase, seems like CI is stuck...

Done

@daxpedda
Copy link
Member

daxpedda commented Sep 8, 2023

CI currently fails because the MSRV for Android is wrong.
#3046 should fix this.

@daxpedda daxpedda force-pushed the fix_android_touch_force branch from e55246a to ee119be Compare September 8, 2023 16:28
@daxpedda daxpedda requested a review from kchibisov September 8, 2023 19:34
@daxpedda
Copy link
Member

daxpedda commented Sep 8, 2023

Rebased it after #3046, CI is green now.

@kchibisov kchibisov merged commit 2422ea3 into rust-windowing:master Sep 22, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants