Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Window::set_ime_position on main thread on macOS #2757

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Run Window::set_ime_position on main thread on macOS #2757

merged 2 commits into from
Apr 14, 2023

Conversation

amatho
Copy link
Contributor

@amatho amatho commented Apr 3, 2023

Fixes #2756.

This fixes a crash when calling Window::set_ime_position from a thread that is not the main thread.

I'm not familiar with the codebase, so feel free to give feedback if I should change anything!

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@amatho amatho requested a review from madsmtm as a code owner April 3, 2023 21:52
@amatho amatho mentioned this pull request Apr 3, 2023
Closed
madsmtm
madsmtm approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on the phone so a bit hard to merge myself, but the change itself looks fine, thanks!

@kchibisov kchibisov merged commit 60e91b1 into rust-windowing:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on macOS when using Window::set_ime_position from another thread
3 participants
@amatho @madsmtm @kchibisov