Implement HasRawDisplayHandle for EventLoop
#2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SludgePhD
force-pushed
the
raw-display-handle-eventloop
branch
from
e1c8bfa to
b6755ba
Compare
SludgePhD
force-pushed
the
raw-display-handle-eventloop
branch
from
b6755ba to
869582d
Compare
madsmtm
approved these changes
Feb 10, 2023
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Mar 1, 2023
* Implement `HasRawDisplayHandle` for `EventLoop` * Add changelog entry
kchibisov
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersThe trait is already implemented for
EventLoopWindowTarget, whichEventLoopderefs to, but that is not enough when using an API that takes aT: HasRawDisplayHandle + 'static(because the API takes ownership of the display handle, in an attempt to offer a safer API to the user than what crates typically do). Also implementing the trait forEventLoopitself solves this problem.(admittedly the use cases for this are rather limited – consuming the
EventLooplike this makes it impossible to actually handle events, and so makes windows useless too, but it is handy when you need a display handle without actually wanting to draw anything; in my specific use case, in order to open a connection to VA-API)