Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Xbox Gamepad support #2543

Closed
wants to merge 2 commits into from
Closed

Initial Xbox Gamepad support #2543

wants to merge 2 commits into from

Conversation

heavyrain266
Copy link

Initial change for #2506 which in the future hopefuly will introduce Xbox platform based on Win32/WinRT APIs which are not under NDA.

Note Windows.Gaming.Input API depends on focused window and Gamepad module provides Xbox specific metadata such as assigned users, which is required for upstream console compatibility.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Signed-off-by: Ignacy Koper <[email protected]>
@heavyrain266
Copy link
Author

@msiglreith Could you help me model this feature as windows specific to not interact with other platforms?

(I've been told on matrix to ping you here)

@msiglreith
Copy link
Member

Have you looked into the old gamepad PR already? #1969
In general it would be nice to keep the user facing API similar if possible but I haven't looked into the new gaming API at all so far besides the comments in the issue

@heavyrain266
Copy link
Author

heavyrain266 commented Nov 1, 2022

Have you looked into the old gamepad PR already? #1969
In general it would be nice to keep the user facing API similar if possible but I haven't looked into the new gaming API at all so far besides the comments in the issue

I have not but someone linked old branch with implementation based on HID instead, thanks for pointing this one out.

New API is a bit different from Xinput as of being rewritten in C++ with more support for more kinds of gaming input than gamepads and requipment for focused window. Users are mostly using gilrs instead which doesn't require any changes in winit itself for cross platform gamepad handling. There is some info about migration, could be mapped 1:1 with previous PR but also add API features required for xbox compatibility on top.

@heavyrain266
Copy link
Author

Unfortunatelly, I'm closing this for now, as I have no time to rebase it and then start testing the new API. I will get back to it in coming months as it requires deeper knowledge of winit internals and a lot of planning and testing.

@heavyrain266 heavyrain266 deleted the wgi branch March 2, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants