Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo-run-wasm #2509

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Oct 3, 2022

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

This PR updates cargo-run-wasm to the latest release.

A common request I have received is to remove the <h1></h1> from the page and give easy access to custom css.
To accommodate that I have reworked the API a little and changed the format of the page.
I have used the body { margin: 0px; } css which is the recommended default css to use as with cargo run-wasm as it gives the wasm app more space to work with by removing the pointless margin.

@rukai rukai force-pushed the update_cargo_run_wasm branch from a93d603 to 9d8eb06 Compare October 9, 2022 01:30
@rukai rukai force-pushed the update_cargo_run_wasm branch from 9d8eb06 to 5fe6b80 Compare October 9, 2022 01:35
@rukai rukai marked this pull request as ready for review October 9, 2022 01:55
@madsmtm madsmtm added DS - web S - maintenance Repaying technical debt labels Oct 9, 2022
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks!

@madsmtm madsmtm merged commit bb0f965 into rust-windowing:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DS - web S - maintenance Repaying technical debt
Development

Successfully merging this pull request may close these issues.

2 participants