Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smithay-client-toolkit to 'v0.15.0' #1990

Merged
merged 2 commits into from
Aug 15, 2021

Conversation

kchibisov
Copy link
Member

@kchibisov kchibisov commented Aug 9, 2021

This commit also drops 'Theme' trait with its support types
in favor of 'FallbackFrame' meaning that winit will use some
predefined frame for the time being, since porting 'ConceptFrame'
will require adding font rendering librarires right into winit,
which is not desired.

@kchibisov
Copy link
Member Author

Since sctk dropped ConceptFrame support new decorations are looking pretty awkward, however considering that other libraries (sdl,glfw) provide poor looking decorations, since everything else is 'complexity & bringing font rendering engines' I don't think that we should port old sctk code at all.

What winit can do is to provide abstractions to work with decorations surfaces and provide buffers to attach to them.

@kchibisov kchibisov requested a review from elinorbgr August 9, 2021 18:29
@kchibisov
Copy link
Member Author

Added @vberger wrt calloop and decorations update.

@maroider
Copy link
Member

maroider commented Aug 9, 2021

Relevant issues:
#1967
Smithay/client-toolkit#196

This commit also drops 'Theme' trait with its support types
in favor of 'FallbackFrame' meaning that winit will use some
predefined frame for the time being, since porting 'ConceptFrame'
will require adding font rendering librarires right into winit,
which is not desired.
@kchibisov kchibisov marked this pull request as ready for review August 13, 2021 21:39
@kchibisov kchibisov changed the title Update smithay-client-toolkit to 'v0.14.0' Update smithay-client-toolkit to 'v0.15.0' Aug 13, 2021
@kchibisov
Copy link
Member Author

kchibisov commented Aug 15, 2021

@chrisduerr I've asked you on irc to review this PR wrt dropping fancy client side decorations, since it's affecting alacritty as the end user. I personally don't really care, since I don't like client side decorations as a concept and would use them purely for 'special' clients or debugging, but we have gnome, thus we're affecting them.

@chrisduerr
Copy link
Contributor

I've asked you on irc to review this PR wrt dropping fancy client side decorations, since it's affecting alacritty as the end user.

I was aware of this already since I was around on IRC when @vberger decided that this was the best approach forward. I somewhat nudged him in that direction when persistently complaining about the font handling of existing decorations.

I think for sctk it makes a lot of sense and I'm not sure it makes sense for winit to step in and provide them. I'd say winit probably comes with similar issues as sctk and will likely fail to provide anything other than super basic decorations with awkward font rendering. So shoving it even further downstream at least should make that easier, since font handling is likely present there already (it is in Alacritty at least).

With an infinite maintenance budget I think this should definitely be handled above application level in winit. But unfortunately that's just not the case. So the approach makes sense.

@kchibisov kchibisov merged commit c9520de into rust-windowing:master Aug 15, 2021
@kchibisov kchibisov deleted the update-sctk-14 branch August 15, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants