-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update smithay-client-toolkit to 'v0.15.0' #1990
Conversation
Since sctk dropped What winit can do is to provide abstractions to work with decorations surfaces and provide buffers to attach to them. |
Added @vberger wrt calloop and decorations update. |
Relevant issues: |
45d37cb
to
c4caa5c
Compare
This commit also drops 'Theme' trait with its support types in favor of 'FallbackFrame' meaning that winit will use some predefined frame for the time being, since porting 'ConceptFrame' will require adding font rendering librarires right into winit, which is not desired.
c4caa5c
to
b561eb0
Compare
@chrisduerr I've asked you on irc to review this PR wrt dropping fancy client side decorations, since it's affecting alacritty as the end user. I personally don't really care, since I don't like client side decorations as a concept and would use them purely for 'special' clients or debugging, but we have gnome, thus we're affecting them. |
I was aware of this already since I was around on IRC when @vberger decided that this was the best approach forward. I somewhat nudged him in that direction when persistently complaining about the font handling of existing decorations. I think for sctk it makes a lot of sense and I'm not sure it makes sense for winit to step in and provide them. I'd say winit probably comes with similar issues as sctk and will likely fail to provide anything other than super basic decorations with awkward font rendering. So shoving it even further downstream at least should make that easier, since font handling is likely present there already (it is in Alacritty at least). With an infinite maintenance budget I think this should definitely be handled above application level in winit. But unfortunately that's just not the case. So the approach makes sense. |
This commit also drops 'Theme' trait with its support types
in favor of 'FallbackFrame' meaning that winit will use some
predefined frame for the time being, since porting 'ConceptFrame'
will require adding font rendering librarires right into winit,
which is not desired.