Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require T: Clone for EventLoopProxy<T>: Clone #1086

Merged
merged 5 commits into from
Aug 5, 2019
Merged

Do not require T: Clone for EventLoopProxy<T>: Clone #1086

merged 5 commits into from
Aug 5, 2019

Conversation

yvt
Copy link
Contributor

@yvt yvt commented Aug 2, 2019 •
edited
Loading

This pull request removes the T: Clone restriction from the Clone impl of EventLoopProxy<T>.

  • Tested on all platforms changed
    • X11
    • Wayland
    • macOS
    • Windows
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@goddessfreya
Copy link
Contributor

goddessfreya commented Aug 2, 2019 •
edited
Loading

Needs a changelog entry, then lgtm. (Assuming it builds)

@yvt yvt mentioned this pull request Aug 2, 2019
Merged
9 tasks
@yvt yvt marked this pull request as ready for review August 2, 2019 03:20
@yvt yvt force-pushed the patch-clone-proxy branch from 55248c7 to 5cae941 Compare August 2, 2019 07:10
@yvt yvt force-pushed the patch-clone-proxy branch from 5cae941 to f2c8afc Compare August 2, 2019 07:11
@yvt
Copy link
Contributor Author

yvt commented Aug 4, 2019 •
edited
Loading

I accidentally tested the wrong branch (my bad!). It should be okay now.

@Osspial Osspial merged commit 73cf10e into rust-windowing:master Aug 5, 2019
cheako pushed a commit to cheako/winit that referenced this pull request Oct 2, 2019
@yvt @cheako
Do not require T: Clone for EventLoopProxy<T>: Clone (rust-window…
47c57dc 
…ing#1086)

* Do not require `T: Clone` for `EventLoopProxy<T>: Clone`

* Update `CHANGELOG.md`

* Remove the conflicting `Clone` impl

* Fix match statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvt @goddessfreya @Osspial