Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode #1065

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode #1065

merged 4 commits into from
Jul 29, 2019

Conversation

dam4rus
Copy link
Contributor

@dam4rus dam4rus commented Jul 23, 2019

Fixes #1047

Tested only on Windows 10, but should work on previous version.

  • Tested on all platforms changed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@Osspial
Copy link
Contributor

Osspial commented Jul 23, 2019 •
edited
Loading

Thanks for implementing this!

These changes look good. All it needs is a changelog entry, and I'll merge it.

EDIT: This behavior should probably have documentation as well.

@dam4rus
Copy link
Contributor Author

dam4rus commented Jul 24, 2019

No problem at all!

Where should i put this behavior in the documentation?

@goddessfreya
Copy link
Contributor

@dam4rus I'd put it here: https://docs.rs/winit/0.20.0-alpha2/winit/window/struct.WindowBuilder.html#method.with_fullscreen

I'd change this function's doc to link to with_fullscreen's doc.

dam4rus pushed a commit to dam4rus/winit that referenced this pull request Jul 26, 2019
Update CHANGELOG.md and documentation to reflect changes from issue r…
007170f 
…ust-windowing#1065
@goddessfreya
Copy link
Contributor

Yes, and now I'd link the two docs like this: https://doc.rust-lang.org/src/alloc/vec.rs.html#284

@dam4rus
Copy link
Contributor Author

dam4rus commented Jul 26, 2019

@zegentzy I've updated the documentation for https://docs.rs/winit/0.20.0-alpha2/winit/window/struct.WindowBuilder.html#method.with_fullscreen, but shouldn't we link all documentation from https://docs.rs/winit/0.20.0-alpha2/winit/window/struct.Window.html to it's WindowBuilder counterpart then? I think it would be weird if only this function is a link to another documentation.

goddessfreya
goddessfreya approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@goddessfreya goddessfreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess that is weird. Could you open a issue for linking all the docs? I think that makes more sense than having to copies of everything. Until then, could you document it in both methods?

@dam4rus dam4rus mentioned this pull request Jul 26, 2019
Closed
@dam4rus
Copy link
Contributor Author

dam4rus commented Jul 26, 2019

I've opened an issue for the docs change

@goddessfreya
Copy link
Contributor

Hey @Osspial, I can't merge this 'cause rustfmt is failing. :(

@goddessfreya goddessfreya mentioned this pull request Jul 28, 2019
Merged
7 tasks
@goddessfreya
Copy link
Contributor

Can you rebase this against master, so that the CI fixes it self?

@goddessfreya goddessfreya merged commit e5ba79d into rust-windowing:master Jul 29, 2019
cheako pushed a commit to cheako/winit that referenced this pull request Oct 2, 2019
@dam4rus @cheako
Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode (rus…
1a7e482 
…t-windowing#1065)

* Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode

Fixes rust-windowing#1047

* Update CHANGELOG.md and documentation to reflect changes from issue rust-windowing#1065

* Updated documentation of window.Window.set_fullscreen to match the documentation of window.WindowBuilder.with_fullscreen.
cheako pushed a commit to cheako/winit that referenced this pull request Oct 19, 2019
@dam4rus @cheako
Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode (rus…
fa86758 
…t-windowing#1065)

* Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode

Fixes rust-windowing#1047

* Update CHANGELOG.md and documentation to reflect changes from issue rust-windowing#1065

* Updated documentation of window.Window.set_fullscreen to match the documentation of window.WindowBuilder.with_fullscreen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goddessfreya goddessfreya goddessfreya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode
3 participants
@dam4rus @Osspial @goddessfreya