Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_user_event should be renamed to new_with_user_events or something like that. #1057

Closed
cheako opened this issue Jul 21, 2019 · 6 comments
Closed

new_user_event should be renamed to new_with_user_events or something like that. #1057

cheako opened this issue Jul 21, 2019 · 6 comments
Labels
D - easy Likely easier than most tasks here H - good first issue Ideal for new contributors P - low Nice to have S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
EventLoop 2.0

Comments

@cheako
Copy link

cheako commented Jul 21, 2019

new_user_event sounds like a helper to create/emit user events, not something one should call to create an event loop.
@goddessfreya goddessfreya added D - easy Likely easier than most tasks here H - good first issue Ideal for new contributors P - low Nice to have S - api Design and usability S - enhancement Wouldn't this be the coolest? labels Jul 21, 2019
@goddessfreya goddessfreya added this to the EventLoop 2.0 milestone Jul 21, 2019
@goddessfreya goddessfreya changed the title new_user_event(): I know it's vary long but new_user_event_loop() is new_user_event_loop() new_user_event should be renamed to new_with_user_events or something like that. Jul 21, 2019
@goddessfreya
Copy link
Contributor

Yeah, new_user_event is a bad name.

@Osspial
Copy link
Contributor

Osspial commented Jul 22, 2019

👍. If you submit a PR implementing this it should get merged pretty quickly.

@briankabiro
Copy link
Contributor

I can take a look at this if that's okay with you, @cheako. Don't want to impose. :)

@cheako
Copy link
Author

cheako commented Jul 23, 2019

@briankabiro go ahead.

@aloucks
Copy link
Contributor

aloucks commented Jul 23, 2019

with_user_event would be more inline with rust naming conventions.

briankabiro added a commit to briankabiro/winit that referenced this issue Jul 24, 2019
@briankabiro
Rename new_user_event to new_with_user_event (rust-windowing#1057)
c1c7947 
Finishes rust-windowing#1057
@briankabiro briankabiro mentioned this issue Jul 24, 2019
Merged
6 tasks
@briankabiro
Copy link
Contributor

Thanks, @cheako.

Also updated it to new_with_user_event and raised a PR. #1068

briankabiro added a commit to briankabiro/winit that referenced this issue Jul 25, 2019
@briankabiro
Rename new_user_event method to with_user_event (rust-windowing#1057
797d82a 
)

Finishes rust-windowing#1057
briankabiro added a commit to briankabiro/winit that referenced this issue Jul 29, 2019
@briankabiro
Rename new_user_event method to with_user_event (rust-windowing#1057
63e1db6 
)

Finishes rust-windowing#1057
briankabiro added a commit to briankabiro/winit that referenced this issue Jul 29, 2019
@briankabiro
Rename new_user_event method to with_user_event (rust-windowing#1057
fbf2fc0 
)

Finishes rust-windowing#1057
briankabiro added a commit to briankabiro/winit that referenced this issue Jul 29, 2019
@briankabiro
Rename new_user_event method to with_user_event (rust-windowing#1057
d03d706 
)

Finishes rust-windowing#1057
goddessfreya pushed a commit that referenced this issue Jul 29, 2019
@briankabiro @goddessfreya
Rename new_user_event method to with_user_event (#1057) (#1068)
131e67d 
Finishes #1057
cheako pushed a commit to cheako/winit that referenced this issue Oct 2, 2019
@briankabiro @cheako
Rename new_user_event method to with_user_event (rust-windowing#1057
fb88f70 
) (rust-windowing#1068)

Finishes rust-windowing#1057
cheako pushed a commit to cheako/winit that referenced this issue Oct 19, 2019
@briankabiro @cheako
Rename new_user_event method to with_user_event (rust-windowing#1057
0a601c8 
) (rust-windowing#1068)

Finishes rust-windowing#1057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D - easy Likely easier than most tasks here H - good first issue Ideal for new contributors P - low Nice to have S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
EventLoop 2.0
Development

No branches or pull requests
5 participants
@aloucks @cheako @Osspial @goddessfreya @briankabiro