Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch events emit screen coordinates instead of client coordinates on Windows #1002

Closed
dam4rus opened this issue Jul 2, 2019 · 0 comments · Fixed by #1042
Closed

Touch events emit screen coordinates instead of client coordinates on Windows #1002

dam4rus opened this issue Jul 2, 2019 · 0 comments · Fixed by #1042
Labels
B - bug Dang, that shouldn't have happened DS - windows H - good first issue Ideal for new contributors

Comments

@dam4rus
Copy link
Contributor

dam4rus commented Jul 2, 2019

As reported in issue #975 the location provided by WM_TOUCH and WM_POINTER events are screen coordinates instead of window client coordinates. These events should emit client coordinates for consistency with the rest of the API and other backends.

This is a change that will break clients using the touch events on Windows though.
@goddessfreya goddessfreya added H - good first issue Ideal for new contributors DS - windows B - bug Dang, that shouldn't have happened labels Jul 3, 2019
dam4rus pushed a commit to dam4rus/winit that referenced this issue Jul 11, 2019
Touch events emit screen coordinates instead of client coordinates on…
44a3c49 
… Windows

Fixes rust-windowing#1002
@dam4rus dam4rus mentioned this issue Jul 11, 2019
Merged
6 tasks
Osspial pushed a commit that referenced this issue Jul 17, 2019
@dam4rus @Osspial
Touch events emit screen coordinates instead of client coordinates on…
8567758 
… Windows (#1042)

* Touch events emit screen coordinates instead of client coordinates on Windows

Fixes #1002

* Don't lose precision of WM_TOUCH events when converting from screen space to client space

* Updated CHANGELOG.md to reflect changes from issue: #1042
felixrabe pushed a commit to felixrabe/winit that referenced this issue Jul 24, 2019
@dam4rus @felixrabe
Touch events emit screen coordinates instead of client coordinates on…
ad9542a 
… Windows (rust-windowing#1042)

* Touch events emit screen coordinates instead of client coordinates on Windows

Fixes rust-windowing#1002

* Don't lose precision of WM_TOUCH events when converting from screen space to client space

* Updated CHANGELOG.md to reflect changes from issue: rust-windowing#1042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened DS - windows H - good first issue Ideal for new contributors
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Touch events emit screen coordinates instead of client coordinates on Windows dam4rus/winit
2 participants
@dam4rus @goddessfreya