fix transparency on macOS #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pre-multiplied is probably wrong for ARGB, should just be Also, this would be incompatible with our docs and other platforms, we tell you to fill the opacity with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.apple.com/documentation/coregraphics/cgimagealphainfo?language=objc
For supporting transparent windows on maOS this is all that is required. I've seen #241 which is adding alpha and it looks significantly more complicated. I might be missing why it is so complicated but this does work and I don't see why it should be any more complicated. I've tested it with tiny_skia.
Using PremultipliedFirst instead of Last because that is consistent with the where the color channels are currently stored.