CI: Generate minimal-versions when build-testing MSRV
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of crates bump their MSRV in simple semver releases, causing us to constantly have to hold back "transitive" dependencies when testing our own MSRV. The opposite way of doing this is by immediately selecting the minimum compatible version per `Cargo.toml` semver selection using `-Zminimal-versions`, with the added benefit of validating our minimal dependency constraints in CI. Unfortunately, even more crates than that don't validate their minimum version dependencies (barring minor improvements for "new" targets), resulting in many compilation failures and many transitive dependencies needing manual update. Strangely, in for example the `image` crate a newer `num-traits 0.2.14` is being used but `num-bigint 0.4.0` fails to compile.
Are you aware of |
madsmtm
approved these changes
Feb 6, 2025
| @@ -81,6 +81,29 @@ jobs: | |||
| with: | |||
| tool: wasm-bindgen-cli | |||
|
|
|||
| - name: Install nightly rust to generate `-Zminimal-versions` lockfile (for MSRV) | |||
| if: matrix.rust_version == '1.71.0' | |||
| uses: dtolnay/rust-toolchain@master | |||
There was a problem hiding this comment.
Nit: Use hecrj/setup-rust-action@v2 (or change both places to use the same).
There was a problem hiding this comment.
Or maybe eschew a GitHub Action-thing, and just do rustup install nightly-... in the bash script below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #259 (comment), CC @madsmtm. Not sure if we want to push ahead with this or first fix all our transitive dependencies... Lots of pain here.
Lots of crates bump their MSRV in simple semver releases, causing us to constantly have to hold back "transitive" dependencies when testing our own MSRV. The opposite way of doing this is by immediately selecting the minimum compatible version per
Cargo.tomlsemver selection using-Zminimal-versions, with the added benefit of validating our minimal dependency constraints in CI.Unfortunately, even more crates than that don't validate their minimum version dependencies (barring minor improvements for "new" targets), resulting in many compilation failures and many transitive dependencies needing manual update. Strangely, in for example the
imagecrate a newernum-traits 0.2.14is being used butnum-bigint 0.4.0fails to compile.