Add MSRV policy regarding wasm-bindgen #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasm-bindgen recently bumped its MSRV to v1.73, which is much higher than our MSRV of 1.64. Add an note to the README describing our MSRV policy, and then test for it in CI. Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Merged
daxpedda
reviewed
Mar 4, 2024
There was a problem hiding this comment.
wasm-bindgens MSRV is v1.60, but bumpalo, one of its dependencies, has been raised. This is hopefully something Cargo can fix in the future: rust-lang/cargo#9930.
Otherwise LGTM.
.github/workflows/ci.yml
Outdated
| @@ -31,7 +31,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| rust_version: ["1.64", stable, nightly] | |||
| rust_version: ["1.64", "1.73", stable, nightly] | |||
There was a problem hiding this comment.
We should rather pin bumpalo, as in daxpedda/web-time@5f49b76.
Comment on lines
+21
to
+22
| When the `wasm-bindgen-0-2` feature is enabled, the MSRV of this crate will be | ||
| raised to the MSRV of the latest version of `wasm-bindgen`. |
There was a problem hiding this comment.
I think this change is good, because wasm-bingen still does not have an official MSRV policy.
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
daxpedda
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-bindgen recently bumped its MSRV to v1.73, which is much higher
than our MSRV of 1.64. Add an note to the README describing our MSRV
policy, and then test for it in CI.
cc @daxpedda