Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #110 to the changelog #112

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Add #110 to the changelog #112

merged 1 commit into from
Mar 17, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Mar 17, 2023

#110 (comment)

Should I also bump the version?

@Lokathor
Copy link
Contributor

I personally use cargo-release to do releases, which can bump the version as part of the release (eg: cargo release patch --execute), so that's not necessary.

I've never been sure if people expect the main branch cargo file to have the version bump already checked in during that version's development, or only bump at the moment of actual release. Unless there's some general "rust projects should do this" guidance in the rust-lang organization somewhere then bumping at the last moment seems okay with me.

@Lokathor Lokathor merged commit f550b4e into master Mar 17, 2023
@notgull notgull deleted the notgull/110-changelog branch March 17, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants