Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #1088

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Misc fixes #1088

merged 2 commits into from
Dec 21, 2018

Conversation

ceyusa
Copy link
Contributor

@ceyusa ceyusa commented Dec 5, 2018

A couple fixes I have seen:

  • Use the "correct" signature for ios raw_handle()
  • silence the compiler with a unused method in certain platforms/os

ceyusa added 2 commits December 5, 2018 12:53
@ceyusa
api: ios: use trait signature in raw_handle()
bc355a1
@ceyusa
egl: remove dead code warning on finish_pbuffer()
6927289 
finish_pbuffer() is only used by android api and windows platform.
This patch enables finish_pbuffer() only for those os.
@francesca64
Copy link
Member

This looks good, thanks!

@francesca64 francesca64 merged commit 0351a24 into rust-windowing:master Dec 21, 2018
@ceyusa ceyusa deleted the misc-fixes branch January 7, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceyusa @francesca64