Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NetBSD platform #1085

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

iquiw
Copy link
Contributor

@iquiw iquiw commented Dec 1, 2018

Test result on NetBSD 8 with Rust 1.30.1.

$ cargo test
    Finished dev [unoptimized + debuginfo] target(s) in 0.09s
     Running target/debug/deps/glutin-6ed9fca4d308c846

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests glutin

running 6 tests
test target/debug/build/glutin-6e1f9d8f4241066e/out/egl_bindings.rs - api::egl::ffi::egl::Egl::load_with (line 375) ...
ignored
test target/debug/build/glutin-6e1f9d8f4241066e/out/glx_bindings.rs - api::glx::ffi::glx::Glx::load_with (line 425) ...
ignored
test target/debug/build/glutin-6e1f9d8f4241066e/out/glx_extra_bindings.rs - api::glx::ffi::glx_extra::Glx::load_with (line 451) ... ignored
test src/lib.rs - GlWindow (line 153) ... ok
test src/lib.rs - Context (line 123) ... ok
test src/lib.rs -  (line 9) ... ok

test result: ok. 3 passed; 0 failed; 3 ignored; 0 measured; 0 filtered out

@francesca64
Copy link
Member

Thanks for the PR, looks good! The CI failure isn't your fault, so don't worry about that. However, it would be nice if you could add a CHANGELOG entry.

@iquiw
Copy link
Contributor Author

iquiw commented Dec 3, 2018

Thanks for the review. OK, I will update CHANGELOG.

* Add "netbsd" as target OS like other BSD's

* Add CHANGELOG entry
@iquiw
Copy link
Contributor Author

iquiw commented Dec 3, 2018

Amended the commit to update CHANGELOG.

@francesca64 francesca64 merged commit 1ad6560 into rust-windowing:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants