Gentz' Misc Changes #1058

goddessfreya · 2018-08-14T06:40:49Z

Adds a way to create opengl contexts from an already existing window.

This might result in suboptimal config for windows on X11, but it should still work.

I currently only plan to implement this functionality on linux and windows. Currently untested.

Implemented:

Tested:

Signed-off-by: Hal Gentz [email protected]

Tested on all platforms changed
Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created an example program if it would help users understand this functionality

Fixes #1089, closes #1091.

kvark · 2018-08-15T14:33:54Z

I assume this is a successor to #942 ?

goddessfreya · 2018-08-15T22:58:14Z

Not really, unlike PureContext, we do make a surface. GlSeparatedContext is identical to a GlWindow, only difference is that the window is stored externally. (And it's window is always made first, something which is inconvenient on X11).

Edit:
The "successor" to PureContext would probably be the new HeadlessContext from this PR: #1029 (which may or may not make a surface)

goddessfreya · 2018-09-16T03:54:51Z

r? @francesca64

msiglreith

just taking a brief look over the changes (only API and windows side)

really looking forward to these changes!

src/lib.rs

msiglreith · 2018-09-23T21:08:52Z

src/lib.rs

+    ///
+    /// Errors should be very rare and only occur in case of permission denied,
+    /// incompatible system, out of memory, etc.
+    pub unsafe fn new_shared(


This function is only temporary until sharing is implemented for all APIs?

No, new_shared is am unsafe variant of new which allows sharing a context with an existing context. It was added because most people don't need context sharing and so would prefer to stay with the safe version.

src/platform/windows/context.rs

msiglreith · 2018-09-23T21:22:38Z

src/platform/windows/context.rs

+                    match *ctxt {
+                        Context::HiddenWindowWgl(_, ref c)
+                            | Context::Wgl(ref c) => c.get_hglrc(),
+                        _ => panic!(),


what's the reason for panic here? Or rather what sort of situation are we facing here?

The context it's being shared with might have been made with EGL. Maybe? Honestly can't remember the reasoning which when behind it anymore.

When I think about it, I'm pretty sure I read somewhere that both shared contexts must have the same OpenGL version (at least on some platforms), which means the user should probably be required to pass us the same GlRequest, so the other context being made with EGL might be impossible.

Anyways, I don't currently have access to the old windows PC I had tested the windows changes on, so I don't want to randomly touch things without being able to test them.

On an unrelated note, the previous and my new version of the windows backend are totally borked, as far as I can tell, as they don't give a flying shit which version the user requested, and GlThenGles doesn't fallback. Does windows even support GLES?

msiglreith · 2018-09-23T21:24:13Z

src/platform/windows/context.rs

                    }
+                    _ => panic!(),


(see remark below)

Raw context support for both Wayland and X11. Add sharing support to windows. Signed-off-by: Hal Gentz <[email protected]>

goddessfreya · 2018-11-15T21:42:35Z

I have resolved the merge conflicts.

goddessfreya · 2018-11-18T04:49:41Z

r? @francesca64

… method, and clarify docs

Signed-off-by: Hal Gentz <[email protected]>

goddessfreya · 2018-12-28T07:09:41Z

Backported @Osspial's changes in #1092

Signed-off-by: Hal Gentz <[email protected]>

This reverts commit da247d3.

Signed-off-by: Hal Gentz <[email protected]>

francesca64 · 2019-02-23T20:25:48Z

So, before this sits here for a whole year... @zegentzy, would you like to maintain glutin? I'm positive you'd be much better at it than me (the iOS backend is the only one I actually know anything about, and I use Metal now anyway), and I'm extremely appreciative that you've been responding to people/etc.

goddessfreya · 2019-02-23T23:09:31Z

@francesca64 I'd be happy to maintain it.

This reverts commit 391fba3. The new headless API does not actually work in situations where X11 is not available. Waiting on rust-windowing/glutin#1058 to make it work right.

Signed-off-by: Hal Gentz <[email protected]>

francesca64 · 2019-02-24T22:35:10Z

@zegentzy great! I sent @tomaka an email about it.

kvark · 2019-02-25T14:30:54Z

@zegentzy if you are about to become the maintainer (which is awesome news!), please pay more attention to the shape of the commits being merged:

Every commit should be compilable on its own in most cases (with an exception of rare cases where the changes grow too big and there is no way to make them compilable before finishing).
Every commit message should tell cleanly what is being done. E.g. messages like "Changes" and "Compile?" are not acceptable. It's fine to have those temporary when you fight CI, for example, but once figured out, you've got to clean those up before asking for a merge.
No need for merge commits (e.g. "Merge branch 'master' into raw-contexts"). They pollute commit history and make bisection difficult since it's no longer linear.

francesca64 · 2019-02-25T18:34:43Z

@kvark "squash and merge" is the only option enabled on glutin, so 1 and 3 won't generally be issues. 2 is super important though.

@zegentzy enjoy your new powers! Please take good care of the CHANGELOG.

kvark · 2019-02-25T18:43:49Z

@francesca64 uh oh, that's quite a weird policy. Merging multi-thousand-LOC PRs just like that is quite destructive (to the history).

francesca64 · 2019-02-25T19:33:35Z

@kvark it's the case with winit as well. It seems to be what tomaka decided on, and is something I have no direct control over. I agree with you, but it hasn't been enough of an issue so far for me to raise the issue with him (...though for Event Loop 2.0 it will definitely be a problem).

goddessfreya · 2019-02-26T00:07:22Z

#1101

useronym · 2019-04-01T16:42:31Z

Did this make it into 0.20? I can't find any docs regarding the separated contexts, and there is no mention of them in the CHANGELOG either.

goddessfreya · 2019-04-02T00:14:44Z

These changes did make it in, but separated contexts were decided against. Rationale was here: #1105 (comment)

For now, instead use the platform-specific RawContextExts:
https://docs.rs/glutin/0.20.0/glutin/os/unix/trait.RawContextExt.html
https://docs.rs/glutin/0.20.0/i686-pc-windows-msvc/glutin/os/windows/trait.RawContextExt.html

goddessfreya · 2019-04-02T00:14:51Z

@Osense

useronym · 2019-04-02T07:40:30Z

@zegentzy I see, thanks!

goddessfreya force-pushed the raw-contexts branch 2 times, most recently from c3bc9cd to 9532b8d Compare August 14, 2018 07:43

goddessfreya mentioned this pull request Aug 15, 2018

Make API fully backend-agnostic gfx-rs/gfx#1619

Closed

5 tasks

goddessfreya mentioned this pull request Aug 26, 2018

[NOMERGE] Merge window creation, attempt 2 gfx-rs/gfx#2347

Closed

1 task

goddessfreya force-pushed the raw-contexts branch from d91e8f6 to 8aba064 Compare August 26, 2018 22:28

goddessfreya changed the title ~~[WIP] Raw contexts~~ [WIP] Raw contexts + context sharing support for windows and linux Sep 5, 2018

goddessfreya force-pushed the raw-contexts branch from 5ca9110 to 6c68c1e Compare September 5, 2018 23:32

goddessfreya mentioned this pull request Sep 5, 2018

Adds context sharing support for the X11 & Wayland backends #1045

Closed

goddessfreya force-pushed the raw-contexts branch 3 times, most recently from 0ce3893 to dcce7ab Compare September 16, 2018 02:38

goddessfreya changed the title ~~[WIP] Raw contexts + context sharing support for windows and linux~~ Raw contexts + context sharing support for windows and linux Sep 16, 2018

msiglreith reviewed Sep 23, 2018

View reviewed changes

Adds context sharing support for the X11 and Wayland backends

a9a17bc

Raw context support for both Wayland and X11. Add sharing support to windows. Signed-off-by: Hal Gentz <[email protected]>

goddessfreya force-pushed the raw-contexts branch from 985a637 to a9a17bc Compare November 15, 2018 21:40

Osspial added 3 commits December 19, 2018 20:18

Unify Context new and new_shared functions, add ContextBuilder::build…

c843a43

… method, and clarify docs

Fix build

cb6a370

Add CHANGELOG entry and fix doc typos

cf90b88

goddessfreya mentioned this pull request Dec 22, 2018

Unify Context new and new_shared functions, add ContextBuilder::buid method, and clarify docs #1092

Merged

goddessfreya added 3 commits December 22, 2018 11:36

Merge branch 'master' into raw-contexts

8bcb807

Merge remote-tracking branch 'osspial/context_api_polish' into HEAD

e6e0a01

"What is safe, shall be safe." --Gentz 23:12

69dedf2

Signed-off-by: Hal Gentz <[email protected]>

goddessfreya changed the title ~~Raw contexts + context sharing support for windows and linux~~ Raw contexts + context sharing support for windows and linux, and Unify Context new and new_shared functions, add ContextBuilder::buid method, and clarify docs Dec 28, 2018

Please the heavens.

1e1f3d5

Signed-off-by: Hal Gentz <[email protected]>

Dlloader

5ee3909

Signed-off-by: Hal Gentz <[email protected]>

goddessfreya mentioned this pull request Feb 17, 2019

Memory Leak when creating and closing more than one window #1073

Closed

goddessfreya added 10 commits February 17, 2019 12:47

Fix

da247d3

Signed-off-by: Hal Gentz <[email protected]>

Revert "Fix"

7918016

This reverts commit da247d3.

Dlloader p2

92d2760

Signed-off-by: Hal Gentz <[email protected]>

Windows fix

9cc9842

Signed-off-by: Hal Gentz <[email protected]>

Rustfmt, android, emscripten

e355f7e

Signed-off-by: Hal Gentz <[email protected]>

Compile?

b307743

Signed-off-by: Hal Gentz <[email protected]>

Compile?

c846793

Signed-off-by: Hal Gentz <[email protected]>

Compile?

e36c488

Signed-off-by: Hal Gentz <[email protected]>

Compile?

4168b25

Signed-off-by: Hal Gentz <[email protected]>

Rebuild

317d599

Signed-off-by: Hal Gentz <[email protected]>

Rebuild

49b9047

Signed-off-by: Hal Gentz <[email protected]>

This was referenced Feb 25, 2019

Allow creating context on existing window #947

Closed

Renderer for headless context is wrong #946

Closed

goddessfreya closed this Feb 26, 2019

robbieh mentioned this pull request Mar 11, 2022

This doesn't build anymore bnewbold/exuberant-hacks#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gentz' Misc Changes #1058

Gentz' Misc Changes #1058

goddessfreya commented Aug 14, 2018 •

edited

Loading

kvark commented Aug 15, 2018

goddessfreya commented Aug 15, 2018 •

edited

Loading

goddessfreya commented Sep 16, 2018

msiglreith left a comment

msiglreith Sep 23, 2018

goddessfreya Sep 23, 2018

msiglreith Sep 23, 2018

goddessfreya Sep 23, 2018

msiglreith Sep 23, 2018

goddessfreya commented Nov 15, 2018

goddessfreya commented Nov 18, 2018

goddessfreya commented Dec 28, 2018

francesca64 commented Feb 23, 2019

goddessfreya commented Feb 23, 2019

francesca64 commented Feb 24, 2019

kvark commented Feb 25, 2019

francesca64 commented Feb 25, 2019

kvark commented Feb 25, 2019

francesca64 commented Feb 25, 2019

goddessfreya commented Feb 26, 2019

useronym commented Apr 1, 2019

goddessfreya commented Apr 2, 2019

goddessfreya commented Apr 2, 2019

useronym commented Apr 2, 2019

Gentz' Misc Changes #1058

Gentz' Misc Changes #1058

Conversation

goddessfreya commented Aug 14, 2018 • edited Loading

kvark commented Aug 15, 2018

goddessfreya commented Aug 15, 2018 • edited Loading

goddessfreya commented Sep 16, 2018

msiglreith left a comment

Choose a reason for hiding this comment

msiglreith Sep 23, 2018

Choose a reason for hiding this comment

goddessfreya Sep 23, 2018

Choose a reason for hiding this comment

msiglreith Sep 23, 2018

Choose a reason for hiding this comment

goddessfreya Sep 23, 2018

Choose a reason for hiding this comment

msiglreith Sep 23, 2018

Choose a reason for hiding this comment

goddessfreya commented Nov 15, 2018

goddessfreya commented Nov 18, 2018

goddessfreya commented Dec 28, 2018

francesca64 commented Feb 23, 2019

goddessfreya commented Feb 23, 2019

francesca64 commented Feb 24, 2019

kvark commented Feb 25, 2019

francesca64 commented Feb 25, 2019

kvark commented Feb 25, 2019

francesca64 commented Feb 25, 2019

goddessfreya commented Feb 26, 2019

useronym commented Apr 1, 2019

goddessfreya commented Apr 2, 2019

goddessfreya commented Apr 2, 2019

useronym commented Apr 2, 2019

goddessfreya commented Aug 14, 2018 •

edited

Loading

goddessfreya commented Aug 15, 2018 •

edited

Loading