Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nix 0.24.1. #25

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Update to nix 0.24.1. #25

merged 2 commits into from
Jun 9, 2022

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Jun 7, 2022

This makes the contents of VsockAddr private, so we have to use the provided methods instead. This is an API-breaking change.

Fixes #24.

@qwandor qwandor requested a review from dpeckett June 7, 2022 13:26
This makes the contents of VsockAddr private, so we have to use the
provided methods instead.

Signed-off-by: Andrew Walbran <[email protected]>
@qwandor qwandor force-pushed the nix branch 2 times, most recently from 23b9fb3 to cc19539 Compare June 7, 2022 14:23
@qwandor qwandor requested a review from Tim-Zhang June 7, 2022 15:38
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
This fixes warnings, but is a breaking API change.

Signed-off-by: Andrew Walbran <[email protected]>
Copy link
Contributor

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @qwandor

@Tim-Zhang
Copy link
Contributor

Tim-Zhang commented Jun 9, 2022

It needs a major version release later, I think we can do it after the remaining draft pull requests merged.

@Tim-Zhang Tim-Zhang merged commit c3a1ed1 into master Jun 9, 2022
@Tim-Zhang Tim-Zhang deleted the nix branch June 9, 2022 07:03
Tim-Zhang added a commit to Tim-Zhang/vsock-rs that referenced this pull request Jul 29, 2022
Bump the major version due to api's updating in rust-vsock#25.

Signed-off-by: Tim Zhang <[email protected]>
@Tim-Zhang Tim-Zhang mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix 0.24 made VsockAddr opaque
2 participants