-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo-all-features
#152
Comments
This is based on `rust-vmm-ci/.buildkite/test_description.json`. We can't run rust-vmm-ci tests because they enable all the features with `--all-features` and our crates have features that may not be compatible with others (e.g. `xen`). Waiting to solve this problem in rust-vmm-ci (see rust-vmm/rust-vmm-ci#152), we use a custom pipeline based on that but that does not use `--all-features`. Signed-off-by: Stefano Garzarella <[email protected]>
This is based on `rust-vmm-ci/.buildkite/test_description.json`. We can't run rust-vmm-ci tests because they enable all the features with `--all-features` and our crates have features that may not be compatible with others (e.g. `xen`). Waiting to solve this problem in rust-vmm-ci (see rust-vmm/rust-vmm-ci#152), we use a custom pipeline based on that but that does not use `--all-features`. Signed-off-by: Stefano Garzarella <[email protected]>
This is based on `rust-vmm-ci/.buildkite/test_description.json`. We can't run rust-vmm-ci tests because they enable all the features with `--all-features` and our crates have features that may not be compatible with others (e.g. `xen`). Waiting to solve this problem in rust-vmm-ci (see rust-vmm/rust-vmm-ci#152), we use a custom pipeline based on that but that does not use `--all-features`. Signed-off-by: Stefano Garzarella <[email protected]>
This is based on `rust-vmm-ci/.buildkite/test_description.json`. We can't run rust-vmm-ci tests because they enable all the features with `--all-features` and our crates have features that may not be compatible with others (e.g. `xen`). Waiting to solve this problem in rust-vmm-ci (see rust-vmm/rust-vmm-ci#152), we use a custom pipeline based on that but that does not use `--all-features`. Signed-off-by: Stefano Garzarella <[email protected]>
An alternative to consider is https://github.com/taiki-e/cargo-hack which runs a cargo subcommand for different target environments and deduplicated feature combinations with the ability of excluding specific combos (e.g. for incompatible features). |
Note for the future: If artifact storage size becomes a problem on CI because of running different feature sets, we could use https://github.com/holmgr/cargo-sweep to cleanup between runs. |
Currently the rust-vmm CI runs
carg test --all-features
see:rust-vmm-ci/.buildkite/test_description.json
Line 25 in 72ebeb3
This doesn't work for certain cases e.g. rust-vmm/vhost#218 (comment).
To test all features while supporting configuration for exclusive features
unittests-gnu
should runcargo test-all-features
using https://github.com/frewsxcv/cargo-all-features.The text was updated successfully, but these errors were encountered: