Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for the new release of mshv crate #193

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

russell-islam
Copy link
Collaborator

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@russell-islam
Copy link
Collaborator Author

russell-islam commented Feb 26, 2025

Even though there is no changes in mshv-bindings, still we have to release to match the version. Otherwise we will get cross version compilations errors.

We are in the process of releasing the new version of mshv crate.

Signed-off-by: Muminul Islam <[email protected]>
Copy link
Collaborator

@NunoDasNeves NunoDasNeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russell-islam russell-islam merged commit 6c6d8cd into main Feb 27, 2025
8 checks passed
@russell-islam russell-islam deleted the muislam/release-034 branch February 27, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants