Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.3.1 #172

Merged
merged 2 commits into from
Oct 30, 2024
Merged

release: v0.3.1 #172

merged 2 commits into from
Oct 30, 2024

Conversation

russell-islam
Copy link
Collaborator

Summary of the PR

Update Cargo.toml with new version number. Release is needed to update CLH with CVM changes

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@russell-islam russell-islam changed the title release: v0.4.0 release: v0.3.1 Oct 23, 2024
@jinankjain
Copy link
Collaborator

Can you please update CHANGELOG.md in both the crates?

@jinankjain
Copy link
Collaborator

I think #175 needs to lands before this change can land.

@NunoDasNeves
Copy link
Collaborator

NunoDasNeves commented Oct 28, 2024

Can you please update CHANGELOG.md in both the crates?

Looks like CHANGELOG.md was added by Wei in 2021, and hasn't been updated since.
Is it really needed, since there's git history and Github release notes? I think we can delete it.

@russell-islam
Copy link
Collaborator Author

Can you please update CHANGELOG.md in both the crates?

Looks like CHANGELOG.md was added by Wei in 2021, and hasn't been updated since. Is it really needed, since there's git history and Github release notes? I think we can delete it.

Agreed.

@jinankjain
Copy link
Collaborator

Can you please update CHANGELOG.md in both the crates?

Looks like CHANGELOG.md was added by Wei in 2021, and hasn't been updated since. Is it really needed, since there's git history and Github release notes? I think we can delete it.

I guess that was mistake in the past. But according to community we should be doing that https://github.com/rust-vmm/community/blob/main/docs/crate_release.md

@russell-islam
Copy link
Collaborator Author

Can you please update CHANGELOG.md in both the crates?

Looks like CHANGELOG.md was added by Wei in 2021, and hasn't been updated since. Is it really needed, since there's git history and Github release notes? I think we can delete it.

I guess that was mistake in the past. But according to community we should be doing that https://github.com/rust-vmm/community/blob/main/docs/crate_release.md

Updated.

@russell-islam russell-islam enabled auto-merge (rebase) October 29, 2024 16:15
@NunoDasNeves
Copy link
Collaborator

LGTM

@jinankjain jinankjain merged commit 67adaff into main Oct 30, 2024
6 checks passed
@jinankjain jinankjain deleted the muislam/v0.4.0 branch October 30, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants