mshv-bindings: Derive constant instead of hard-coding #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
jinankjain
force-pushed
the
derive_const
branch
from
dadc44e
to
b8126c1
Compare
liuw
approved these changes
Apr 14, 2024
Constants like LAPIC_STATE size could be derived by calling size_of on the struct LapicState. In the similar fashion, other values can also be derived. Use a const function to intialize the various component sizes. Signed-off-by: Jinank Jain <[email protected]>
jinankjain
force-pushed
the
derive_const
branch
from
b8126c1
to
f70a59d
Compare
russell-islam
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Constants like LAPIC_STATE size could be derived by calling size_of on the struct LapicState. In the similar fashion, other values can also be derived. Use a const function to intialize the various component sizes.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.