Fix rand dependency version in rand_distr #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rand_distr` works with neither `rand` `0.5.6` (the latest version of `0.5.*`) nor `0.6.5` (the latest version of `0.6.*`). In other words, if I change the dependency to `rand = "0.5"` or `rand = "0.6"`, then `cargo check` fails.
|
I can reproduce that using 0.5 or 0.6 does not work, but I'm not sure why. I don't think |
|
I recall hitting this issue too but not a solution. However I think there's no need for back-compatibility anyway, thus we may as well merge this @vks? |
|
Might it be related to using workspaces? In any case, I agree that we don't need the backwards compatibility and that this should be merged. (If we later decide to maintain backwards compatibility, we should fix it and make sure it is tested by CI.) |
vks
approved these changes
Jul 24, 2019
|
Well, the reason for the incompatibility is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand_distrworks with neitherrand0.5.6(the latest version of0.5.*) nor0.6.5(the latest version of0.6.*). In other words, if I change the dependency torand = "0.5"orrand = "0.6", thencargo checkfails.