Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand_distr: Prepare 0.1 and 0.2 release #816

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

vks
Copy link
Collaborator

@vks vks commented Jun 5, 2019

For the 0.1 release, I suggest to branch off b21713a, update the changelog and publish it on crates.io.

@vks vks mentioned this pull request Jun 5, 2019
22 tasks
@dhardy dhardy merged commit cdf9a16 into rust-random:master Jun 5, 2019
@vks vks deleted the rand_distr-0.2 branch June 5, 2019 13:52
@dhardy
Copy link
Member

dhardy commented Jun 6, 2019

There is a problem: rand_distr's util module has use rand::distributions::hidden_export::IntoFloat; which isn't in Rand prior to 0.7, thus I cannot publish rand_distr first.

I also cannot publish rand first because it depends on rand_distr for benchmarks. So we could:

  1. remove those benchmarks temporarily for 0.7.0-pre.0 then add them back
  2. move the benchmarks into rand_distr
  3. copy the IntoFloat code to avoid that dependency

I'm tempted just to do the simplest thing (1) for now.

@vks
Copy link
Collaborator Author

vks commented Jun 6, 2019

I would suggest to remove the benchmarks for now, and add them to rand_distr later.

@dhardy
Copy link
Member

dhardy commented Jun 6, 2019

I actually implemented 3 (just for rand_distr 0.1). But still can't publish until I sort out the compatibility shim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants